feat: added link to YT video to TSC page #1141

Anurag607 · 2022-12-05T13:51:20Z

Description

Added YT video link that explains how to join TSC to TSC page
The Link is added in the Question Card.

Related issue(s)

Resolves #809

Before :

After :

netlify · 2022-12-05T13:51:26Z

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`8820aba`
🔍 Latest deploy log	https://app.netlify.com/sites/asyncapi-website/deploys/638f295ecccd0100091aa0a4
😎 Deploy Preview	https://deploy-preview-1141--asyncapi-website.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

github-actions · 2022-12-05T13:53:45Z

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🔴 Performance	49
🟠 Accessibility	88
🟠 Best practices	83
🟢 SEO	100
🔴 PWA	30

Lighthouse ran on https://deploy-preview-1141--asyncapi-website.netlify.app/

akshatnema

Want to have some discussion here regarding the place it is to be added.

@derberg @Anurag607 I find this place to be more appropriate to add the Youtube tutorial link for TSC members, as it describes the notion of the video as well as it is at the top of the page. WDYT?

akshatnema · 2022-12-05T14:25:45Z

pages/community/tsc.js

+      <div className="my-4">
+        Want to become a member?
+        Follow this
+        <Link href='https://www.youtube.com/watch?v=uG_aLF9Z1F0'>


Please, use TextLink component https://github.com/asyncapi/website/blob/master/components/typography/TextLink.js, along with target="blank" to open the video in new tab.

derberg · 2022-12-05T14:38:07Z

actually both locations are good. We can have it in both

Anurag607 · 2022-12-05T14:45:06Z

@derberg @akshatnema, so should I add it in the Question Card or at the end of the paragraph?
Also I think if the link were to be added in the paragraph, then the card will not be needed

akshatnema · 2022-12-05T14:46:40Z

@derberg @akshatnema, so should I add it in the Question Card or at the end of the paragraph?
Also I think if the link were to be added in the paragraph, then the card will not be needed

It's better you do both implementations.

Anurag607 · 2022-12-05T15:01:31Z

I've added links to both the TSC para and the question Card and used TextLink instead of Link

akshatnema · 2022-12-05T16:39:13Z

pages/community/tsc.js

@@ -72,6 +73,11 @@ export default function TSC() {
              can also build a great AsyncAPI-based project that we don't have
              yet in our GitHub organization and donate it (we'll ask you to
              stay as a maintainer).
+              Follow this
+              <TextLink href="https://www.youtube.com/watch?v=uG_aLF9Z1F0" target="_blank" className="text-base text-blue-500 hover:text-sky-400 no-underline">


Suggested change

<TextLink href="https://www.youtube.com/watch?v=uG_aLF9Z1F0" target="_blank" className="text-base text-blue-500 hover:text-sky-400 no-underline">

<TextLink href="https://www.youtube.com/watch?v=uG_aLF9Z1F0" target="_blank" className="text-base font-normal text-blue-500 hover:text-sky-400 no-underline">

The font-weight of the text is getting large, so it should be made according to the remaining text in the paragraph.

akshatnema · 2022-12-05T16:42:04Z

pages/community/tsc.js

+      <div className="my-4">
+        Want to become a member?
+        Follow this
+        <TextLink href="https://www.youtube.com/watch?v=uG_aLF9Z1F0" target="_blank" className="text-sky-600 hover:text-sky-400 no-underline">


Suggested change

<TextLink href="https://www.youtube.com/watch?v=uG_aLF9Z1F0" target="_blank" className="text-sky-600 hover:text-sky-400 no-underline">

<TextLink href="https://www.youtube.com/watch?v=uG_aLF9Z1F0" target="_blank" className="font-normal text-sky-600 hover:text-sky-400 no-underline">

same here

derberg · 2022-12-05T19:42:54Z

instead of old YT recording we finally have an official document you can link to -> https://github.com/asyncapi/community/blob/master/TSC_MEMBERSHIP.md

Anurag607 · 2022-12-06T02:18:21Z

@derberg I will then replace the YT link with the docs link

akshatnema · 2022-12-06T08:29:12Z

@Anurag607 I see that the above CSS attributes are still not applied even after adding classes. Kindly add twMerge function in the className of the TextLink component to modify the component according to the changes we need. You can take reference from here - https://github.com/asyncapi/website/blob/master/components/buttons/Button.js#L17

Anurag607 · 2022-12-06T09:08:55Z

@akshatnema I have updated the PR according to the review

…into local

akshatnema · 2022-12-06T09:11:18Z

pages/community/tsc.js

@@ -72,6 +74,11 @@ export default function TSC() {
              can also build a great AsyncAPI-based project that we don't have
              yet in our GitHub organization and donate it (we'll ask you to
              stay as a maintainer).
+              Follow this
+              <TextLink href="https://github.com/asyncapi/community/blob/master/TSC_MEMBERSHIP.md" target="_blank" className={twMerge(`text-base font-normal text-blue-500 hover:text-sky-400 no-underline`)}>


Please remove the twMerge function from file as it is not needed here.

I have updated the PR according to the review

akshatnema

LGTM @Anurag607, anything from your side @derberg?

derberg · 2022-12-06T12:18:16Z

I'm good, thanks so much @Anurag607 !

akshatnema · 2022-12-06T12:29:07Z

/rtm

Anurag607 added 5 commits December 5, 2022 14:20

feat(enhancement) : added link to YT video to TSC page

a455f46

feat: add YT link to TSC para and question card

a4a240f

feat: add YT link to TSC para and question card

2acf190

feat: alter font weight of the link

6915e9f

feat: replace old YT link with new docs link

f693cb4

Anurag607 requested review from fmvilas, derberg, mcturco, akshatnema, magicmatatjahu and asyncapi-bot-eve as code owners December 5, 2022 13:51

github-actions bot reviewed Dec 5, 2022

View reviewed changes

Anurag607 changed the title ~~feat(enhancement) : added link to YT video to TSC page~~ feat : added link to YT video to TSC page Dec 5, 2022

Anurag607 changed the title ~~feat : added link to YT video to TSC page~~ feat: added link to YT video to TSC page Dec 5, 2022

akshatnema requested changes Dec 5, 2022

View reviewed changes

akshatnema reviewed Dec 5, 2022

View reviewed changes

Anurag607 added 2 commits December 5, 2022 22:45

feat: fixed font weight issues in TextLink component

72e3dca

feat: fixed font weight issues in TextLink component

7033ef2

Merge branch 'master' into local

8b67c2c

Merge branch 'local' of https://github.com/Anurag607/AsyncAPI-Website …

2fe0324

…into local

akshatnema reviewed Dec 6, 2022

View reviewed changes

Merge branch 'master' into local

8820aba

akshatnema approved these changes Dec 6, 2022

View reviewed changes

asyncapi-bot added the ready-to-merge label Dec 6, 2022

asyncapi-bot merged commit 32e0178 into asyncapi:master Dec 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: added link to YT video to TSC page #1141

feat: added link to YT video to TSC page #1141

Anurag607 commented Dec 5, 2022

netlify bot commented Dec 5, 2022 •

edited

Loading

github-actions bot left a comment

github-actions bot commented Dec 5, 2022 •

edited

Loading

akshatnema left a comment

akshatnema Dec 5, 2022

derberg commented Dec 5, 2022

Anurag607 commented Dec 5, 2022

akshatnema commented Dec 5, 2022

Anurag607 commented Dec 5, 2022

akshatnema Dec 5, 2022

Anurag607 Dec 5, 2022

akshatnema Dec 5, 2022

Anurag607 Dec 5, 2022

derberg commented Dec 5, 2022

Anurag607 commented Dec 6, 2022

akshatnema commented Dec 6, 2022

Anurag607 commented Dec 6, 2022

akshatnema Dec 6, 2022

Anurag607 Dec 6, 2022

akshatnema left a comment

derberg commented Dec 6, 2022

akshatnema commented Dec 6, 2022

	<TextLink href="https://www.youtube.com/watch?v=uG_aLF9Z1F0" target="_blank" className="text-base text-blue-500 hover:text-sky-400 no-underline">
	<TextLink href="https://www.youtube.com/watch?v=uG_aLF9Z1F0" target="_blank" className="text-base font-normal text-blue-500 hover:text-sky-400 no-underline">

feat: added link to YT video to TSC page #1141

feat: added link to YT video to TSC page #1141

Conversation

Anurag607 commented Dec 5, 2022

netlify bot commented Dec 5, 2022 • edited Loading

✅ Deploy Preview for asyncapi-website ready!

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 5, 2022 • edited Loading

akshatnema left a comment

Choose a reason for hiding this comment

akshatnema Dec 5, 2022

Choose a reason for hiding this comment

derberg commented Dec 5, 2022

Anurag607 commented Dec 5, 2022

akshatnema commented Dec 5, 2022

Anurag607 commented Dec 5, 2022

akshatnema Dec 5, 2022

Choose a reason for hiding this comment

Anurag607 Dec 5, 2022

Choose a reason for hiding this comment

akshatnema Dec 5, 2022

Choose a reason for hiding this comment

Anurag607 Dec 5, 2022

Choose a reason for hiding this comment

derberg commented Dec 5, 2022

Anurag607 commented Dec 6, 2022

akshatnema commented Dec 6, 2022

Anurag607 commented Dec 6, 2022

akshatnema Dec 6, 2022

Choose a reason for hiding this comment

Anurag607 Dec 6, 2022

Choose a reason for hiding this comment

akshatnema left a comment

Choose a reason for hiding this comment

derberg commented Dec 6, 2022

akshatnema commented Dec 6, 2022

netlify bot commented Dec 5, 2022 •

edited

Loading

github-actions bot commented Dec 5, 2022 •

edited

Loading